会話一覧の最新化 #59
Merged
会話一覧の最新化 #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wadabee
commented
Sep 4, 2023
Comment on lines
+34
to
+38
| post: ( | ||
| id: string, | ||
| content: string, | ||
| mutateListChat: KeyedMutator<ListChatsResponse> | ||
| ) => void; |
There was a problem hiding this comment.
ZsutandとSWRの相性問題があり、Zsutandの中でSWRを実行するとエラーになってしまうので、Mutate関数を渡す実装にしました。
wadabee
commented
Sep 4, 2023
Comment on lines
+111
to
+125
| <Markdown> | ||
| {message.content + | ||
| `${ | ||
| loading && | ||
| idx === messages.length - 1 && | ||
| messages[idx].content !== '' | ||
| ? '▍' | ||
| : '' | ||
| }`} | ||
| </Markdown> | ||
| {loading && | ||
| message.role === 'assistant' && | ||
| idx === messages.length - 1 && ( | ||
| <div className="animate-pulse text-2xl text-gray-700"> | ||
| <PiDotsThree /> | ||
| </div> | ||
| idx === messages.length - 1 && | ||
| messages[idx].content === '' && ( | ||
| <div className="animate-pulse text-gray-700">▍</div> |
There was a problem hiding this comment.
Loading表示の修正を入れ忘れていたので、こちらも修正しました。
tbrand
approved these changes
Sep 4, 2023
| const getLabelByPath = (path: string) => { | ||
| const getLabelByPath = (_path: string) => { | ||
| // MEMO: /chat/:chatId の path の場合に件名が表示されないため、以下の実装としている | ||
| const path = '/' + _path.split('/')[1]; |
There was a problem hiding this comment.
これそうなんすよねぇ〜自分も気になってました。タイトルが出せると良いのにと。Issue 化しておきます！
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#41
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.